Re: CVS: [MR] wxWidgets configure.in,1.1103,1.1104

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: CVS: [MR] wxWidgets configure.in,1.1103,1.1104

Vadim Zeitlin-3
On 16 Jan 2006 15:42:44 -0000 [hidden email] wrote:

> Update of /pack/cvsroots/wxwidgets/wxWidgets
> In directory sunsite.dk:/tmp/cvs-serv15909
>
> Modified Files:
> configure.in
> Log Message:
> GTK_NO_CHECK_CASTS is a gtk1 only thing, so don't put it to CPPFLAGS with gtk2.
> It's been renamed to G_NO_CHECK_CASTS in gtk2 stack, but we don't appear to need it.
> Why do we need to supress cast checks for gtk1?

 I could be wrong but I thought it was an optimization. I.e. just like
removing asserts in non debug builds.

 Regards,
VZ


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Re: CVS: [MR] wxWidgets configure.in,1.1103,1.1104

Mart Raudsepp
On Mon, 2006-01-16 at 17:42 +0100, Vadim Zeitlin wrote:

> On 16 Jan 2006 15:42:44 -0000 [hidden email] wrote:
>
> > Update of /pack/cvsroots/wxwidgets/wxWidgets
> > In directory sunsite.dk:/tmp/cvs-serv15909
> >
> > Modified Files:
> > configure.in
> > Log Message:
> > GTK_NO_CHECK_CASTS is a gtk1 only thing, so don't put it to CPPFLAGS with gtk2.
> > It's been renamed to G_NO_CHECK_CASTS in gtk2 stack, but we don't appear to need it.
> > Why do we need to supress cast checks for gtk1?
>
>  I could be wrong but I thought it was an optimization. I.e. just like
> removing asserts in non debug builds.

OK, thanks.
I'll try to investigate this later. It certainly shouldn't be
unconditionally set, maybe just for release builds.
It didn't work anyway for gtk2, as it would have to be G_NO_CHECK_CASTS
for that. G_NO_CHECK_CASTS can be later on added as an elif if deemed
necessary.

--
With regards,
Mart Raudsepp

Project manager of wxMUD
E-mail: [hidden email]
http://wxmud.sourceforge.net/


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re[2]: Re: CVS: [MR] wxWidgets configure.in,1.1103,1.1104

Vadim Zeitlin-3
On Mon, 16 Jan 2006 18:45:35 +0200 Mart Raudsepp <[hidden email]> wrote:

MR> > > GTK_NO_CHECK_CASTS is a gtk1 only thing, so don't put it to CPPFLAGS with gtk2.
MR> > > It's been renamed to G_NO_CHECK_CASTS in gtk2 stack, but we don't appear to need it.
MR> > > Why do we need to supress cast checks for gtk1?
MR> >
MR> >  I could be wrong but I thought it was an optimization. I.e. just like
MR> > removing asserts in non debug builds.
MR>
MR> OK, thanks.
MR> I'll try to investigate this later. It certainly shouldn't be
MR> unconditionally set, maybe just for release builds.

 Well, this is the case currently: it's in "else" branch of
wxUSE_DEBUG_FLAG test.

MR> It didn't work anyway for gtk2, as it would have to be G_NO_CHECK_CASTS
MR> for that. G_NO_CHECK_CASTS can be later on added as an elif if deemed
MR> necessary.

 I think it should be done, thanks for noticing this.

 Regards,
VZ


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]